Skip to content

Add cherry-pick-approved label, require it for release branches #3993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Jun 6, 2019
Merged

Add cherry-pick-approved label, require it for release branches #3993

openshift-merge-robot merged 1 commit into from
Jun 6, 2019

Conversation

@stevekuznetsov
Copy link
Contributor

@stevekuznetsov stevekuznetsov commented Jun 6, 2019

Signed-off-by: Steve Kuznetsov [email protected]

/assign @derekwaynecarr @jwforres

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 6, 2019
@jwforres
Copy link
Member

jwforres commented Jun 6, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 6, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 6, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jwforres, stevekuznetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit dfbd6ee into openshift:master Jun 6, 2019
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 6, 2019

@stevekuznetsov: Updated the following 2 configmaps:

  • config configmap in namespace ci using the following files:
    • key config.yaml using file cluster/ci/config/prow/config.yaml
  • labels configmap in namespace ci using the following files:
    • key labels.yaml using file cluster/ci/config/prow/labels.yaml
Details

In response to this:

Signed-off-by: Steve Kuznetsov [email protected]

/assign @derekwaynecarr @jwforres

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wking wking mentioned this pull request Jun 6, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hongkailiu hongkailiu Awaiting requested review from hongkailiu

@petr-muller petr-muller Awaiting requested review from petr-muller

Assignees

@jwforres jwforres

@derekwaynecarr derekwaynecarr

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@stevekuznetsov @jwforres @openshift-ci-robot @derekwaynecarr @openshift-merge-robot